sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SQOOP-1870) IDF API and impementation package depednency
Date Wed, 10 Dec 2014 16:30:15 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241333#comment-14241333
] 

Veena Basavaraj edited comment on SQOOP-1870 at 12/10/14 4:29 PM:
------------------------------------------------------------------

there wont be any connector-sdk, it is the connector-utils.

You seem to have a strong objection in my last patch, when I removed the CSVIntermediaterDataFormat
as a default in the SqoopConnector class.

If we need this as a default just keep CSVIntermediaterDataFormat in the SPI. Simialrly the
matcher  API and its default implementatio can be in SPI as well, I see no value add in separating
the SPI and SDK since both are depending on each other in cyclical way

There will be connector-utils that hosts any util classes, that can be used in tests as well

As far as fixing tests not to use CSVIntermediateDataFormat and infact mock or a TestIDF the,
it is separate issue that should be fixed. U


was (Author: vybs):
there wont be any connector-sdk, it is the connector-utils.

You seem to have a strong objection in my last patch, when I removed the CSVIntermediaterDataFormat
as a default in the SqoopConnector class.

If we need this as a default just keep this in the SPI. Simialrly the matcher  API and its
default implementatio can be in SPI as well, I see no value add in separating the two since
both are depending on each other.

There will be connector-utils that hosts any util classes, that can be used in tests as well

As far as fixing tests not to use CSVIntermediateDataFormat and infact mock or a TestIDF the,
it is separate issue that should be fixed. U

> IDF API and impementation package depednency
> --------------------------------------------
>
>                 Key: SQOOP-1870
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1870
>             Project: Sqoop
>          Issue Type: Bug
>          Components: sqoop2-framework
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>
> Currently the IDF API is in connector SDK package, 
> The right place for IDF API is sqoop-spi package since custom implementations of the
IDF can be done in future.
> Instead today sqoop SPI that holds connectors depends on SDK which in fact should be
the other way round, the connector API is the root and should not depend on its implemenation
package.
> connector SDK was intended to hold concrete implementations and some extent utility classes
that  the connectors use, there is obvioulsy some leaks and execution engine even depends
on connecto-rsdk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message