sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 29346: Supporting DRY code in new IDF impementation JSONIDF
Date Thu, 01 Jan 2015 02:06:22 GMT


> On Dec. 30, 2014, 11:15 a.m., Abraham Elmahrek wrote:
> > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java,
line 34
> > <https://reviews.apache.org/r/29346/diff/8/?file=801554#file801554line34>
> >
> >     CSV

good catch.!


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29346/#review66332
-----------------------------------------------------------


On Dec. 26, 2014, 11:50 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29346/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 11:50 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1901
>     https://issues.apache.org/jira/browse/SQOOP-1901
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jIRA
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/schema/Schema.java 5951e36 
>   common/src/main/java/org/apache/sqoop/schema/SchemaError.java 33e4672 
>   connector/connector-sdk/pom.xml 38c217a 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
48adae1 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
846aefd 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java
884550d 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
7ac44dc 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java
PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormatError.java
PRE-CREATION 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
f6852a0 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java
PRE-CREATION 
>   pom.xml afdeb75 
> 
> Diff: https://reviews.apache.org/r/29346/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message