sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ricky Nguyen" <ricky.ngu...@gmail.com>
Subject Review Request 29578: fix and unit test for SQOOP-1826
Date Mon, 05 Jan 2015 09:20:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29578/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-1826
    https://issues.apache.org/jira/browse/SQOOP-1826


Repository: sqoop-trunk


Description
-------

fix and test NPE bug encountered in SQOOP-1826


Diffs
-----

  src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 8d4a097 
  src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 3b5731b 

Diff: https://reviews.apache.org/r/29578/diff/


Testing
-------

added test testDirectIncrementalImport.  test currently passes (regardless of this fix).
added test testDirectIncrementalImportMerge.  test fails and reproduces NPE in SQOOP-1826.
 test passes with the fix.

with fix, all tests in PostgresqlImportTest pass.


Thanks,

Ricky Nguyen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message