sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 29565: Sqoop2: Rearrange LinkConfig and ToJobConfig of KiteConnector
Date Tue, 06 Jan 2015 09:12:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29565/#review66811
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Jan. 6, 2015, 8:03 a.m., Qian Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29565/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 8:03 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1751
>     https://issues.apache.org/jira/browse/SQOOP-1751
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> This is a follow up jira of SQOOP-1588. 
> 
> Two things should be changed:
> 1. The File Output Format should be moved to ToJobConfig. 
> 2. Credential configs should be kept in LinkConfig (such as HDFS host and port, which
should be read from environment or here, not from toJobConfig.uri)
> 
> Note that the current upgrade api does not allow `toJobConfig` or `fromJobConfig` to
access original `linkConfig` (also in reverse direction), so it is not able to read valueFoo
from linkConfig into toJobConfig. I fallback to a default value manually.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/validation/validators/DatasetURIValidator.java
PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/validation/validators/HostAndPortValidator.java
PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/validation/validators/TestHostAndPortValidator.java
PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java
d3b9f95 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java
0a46f4a 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java
25912b4 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java
11233a8 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ConfigUtil.java
PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java
89bd9b3 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java
70b7dc3 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/InputValidation.java
53fab02 
>   connector/connector-kite/src/main/resources/kite-connector-config.properties 27c77b4

>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java
a1016a0 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java
4051fda 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java
5f0525d 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/configuration/TestConfigUtil.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29565/diff/
> 
> 
> Testing
> -------
> 
> Added test cases to check config objects are expected after upgrade.
> 
> 
> Thanks,
> 
> Qian Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message