sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 29826: SQOOP-1991: Sqoop2: Define slow category in integration tests
Date Thu, 15 Jan 2015 15:45:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29826/#review68258
-----------------------------------------------------------

Ship it!


I have just one small nit, otherwise it looks good to me.


dev-support/test-patch.py
<https://reviews.apache.org/r/29826/#comment112426>

    We should run all tests in the pre-commit hook, including the slow unit tests as committers
(=me) are sometimes depending on the pre-commit hook (e.g. I'm not running all test prior
commit).


- Jarek Cecho


On Jan. 13, 2015, 6:04 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29826/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 6:04 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1991
>     https://issues.apache.org/jira/browse/SQOOP-1991
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit de382f9cd4826c003bbe73e9ed34cbc17863f483
> Author: Abraham Elmahrek <abe@apache.org>
> Date:   Mon Jan 12 14:52:16 2015 -0800
> 
>     SQOOP-1991: Sqoop2: Define slow category in integration tests
> 
> :100755 100755 6b0218b... 97f3cdb... M  dev-support/test-patch.py
> :100644 100644 3297c00... 3fd3443... M  pom.xml
> :100644 100644 352fb26... f69f08c... M  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
> 
> 
> Diffs
> -----
> 
>   dev-support/test-patch.py 6b0218b 
>   pom.xml 3297c00 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
352fb26 
> 
> Diff: https://reviews.apache.org/r/29826/diff/
> 
> 
> Testing
> -------
> 
> mvn integration-test runs without partition tests
> mvn integration-test -Dslow -Phadoop200 runs with partition tests
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message