sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration tests
Date Thu, 15 Jan 2015 15:53:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68259
-----------------------------------------------------------



common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment112427>

    We are not closing the PreparedStatement.



common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java
<https://reviews.apache.org/r/29749/#comment112428>

    I'm wondering what is the reason to drop the proper escaping?



repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java
<https://reviews.apache.org/r/29749/#comment112429>

    PostgreSQL repository version 1 will be in 1.99.5. The version 1.99.4 has been already
released and PostgreSQL repo hasn't been there :)



repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java
<https://reviews.apache.org/r/29749/#comment112430>

    I'm not sure why did we moved the main implementation into package "integration"? I though
that this package "integration" is for integration tests only (e.g. not for "real" code).


- Jarek Cecho


On Jan. 13, 2015, 5:38 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 5:38 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1591
>     https://issues.apache.org/jira/browse/SQOOP-1591
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <abe@apache.org>
> Date:   Wed Jan 7 20:44:44 2015 -0800
> 
>     SQOOP-1591: Sqoop2: PostgreSQL integration tests
> 
> :100644 100644 8196fe2... cb987f6... M  common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M  common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
> 
> 
> Diffs
> -----
> 
>   common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
fb4e7af 
>   common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8

>   common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d

>   repository/repository-postgresql/pom.xml 0ee9081 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java
PRE-CREATION 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java
PRE-CREATION 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java
PRE-CREATION 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java
PRE-CREATION 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java
PRE-CREATION 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java
PRE-CREATION 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
bdefd4c 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java
19ee505 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
4013d22 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
e645c7d 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
39abb2d 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
a6319ac 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java
PRE-CREATION 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
ea199d4 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java
f393521 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
6075de4 
> 
> Diff: https://reviews.apache.org/r/29749/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider
-Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test
-Dsqoop.provider.postgresql.password=test
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message