sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1901) Sqoop2: Support DRY code in IDF impementations and add JSONIDF
Date Tue, 06 Jan 2015 03:49:35 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265653#comment-14265653

Hudson commented on SQOOP-1901:

SUCCESS: Integrated in Sqoop2-hadoop200 #688 (See [https://builds.apache.org/job/Sqoop2-hadoop200/688/])
SQOOP-1901: Sqoop2: Support DRY code in IDF impementations and add JSONIDF (abe: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4ffa806bace0fbe7cb922ef6d80ae0c5d891bfca)
* connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
* pom.xml
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
* connector/connector-sdk/pom.xml
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java
* common/src/main/java/org/apache/sqoop/schema/SchemaError.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java
* connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormatError.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
* common/src/main/java/org/apache/sqoop/schema/Schema.java

> Sqoop2: Support DRY code in IDF impementations and add JSONIDF
> --------------------------------------------------------------
>                 Key: SQOOP-1901
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1901
>             Project: Sqoop
>          Issue Type: Sub-task
>          Components: sqoop2-framework
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>         Attachments: SQOOP-1901-v2.patch, SQOOP-1901-v4.patch, SQOOP-1901-v5.patch, SQOOP-1901-v6.patch
> As the title suggests, we want to encourage DRY code in the new IDF implementations.
> As the IDF api mandates CSV and object format for all its sub implementation, I propose
we move the common functionality to the base IDF class so that JSON IDF or AvroIDF does not
have to repeat this code.
> The only parts of the code that needs to be in subclasses is how then handle the conversion
between the "T" ( generic parameter) and the csv/ object representations.
> I saw that http://ingest.tips/2014/12/11/sqoop-1-99-4-release/ mentions extensind from
CSVIDF and this cannot technically work since we have the generic T that will be different
for AvroIDF or JSON IDF
> Update:
> Also extending from CSVIDF seems a bit ilogical, since the IDF API says that it needs
CSV and object Array, these functionality of converting between the two i.e text to object
and object to text should be in base class.

This message was sent by Atlassian JIRA

View raw message