sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1968) Optimize schema operation in getMatchingData of NameMatcher
Date Wed, 07 Jan 2015 11:13:34 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267525#comment-14267525

ASF subversion and git services commented on SQOOP-1968:

Commit 60066b8f3873cd322735a7b822b9eac16e24c0fc in sqoop's branch refs/heads/sqoop2 from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=60066b8 ]

SQOOP-1968: Optimize schema operation in getMatchingData of NameMatcher

(Qian Xu via Jarek Jarcec Cecho)

> Optimize schema operation in getMatchingData of NameMatcher
> -----------------------------------------------------------
>                 Key: SQOOP-1968
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1968
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: connectors/generic
>    Affects Versions: 2.0.0
>            Reporter: Jerry Chen
>            Assignee: Qian Xu
>         Attachments: SQOOP-1968.2.patch, SQOOP-1968.3.patch, SQOOP-1968.patch
> Two performance issues found in the Matcher implementations.
> 1. In getMatchingData  of NameMatcher, the following code block of building a HashMap
will not change across different getMatchingData  calls. The HashMap can build only once in
> {code}
> HashMap<String,Column> colNames = new HashMap<String, Column>();
> for (Column fromCol: getFromSchema().getColumnsArray()) {
>   colNames.put(fromCol.getName(), fromCol);
> }
> {code}
> 2. In getMatchingData  of NameMatcher, indexOf of a List implementation is not efficient.
It usually involves a loop for finding the object and return the index. To improve, we can
simple store the index in the above HashMap and retrieve the index by HashMap lookup directly
> {code}
> int fromIndex = getFromSchema().getColumnsList().indexOf(fromCol);
> {code}
> These performance problems are critical because getMatchingData is repeatedly calling
for each record.

This message was sent by Atlassian JIRA

View raw message