sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sqoop QA bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1969) Support getColumnSize method for Schema class
Date Mon, 05 Jan 2015 09:37:34 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264404#comment-14264404

Sqoop QA bot commented on SQOOP-1969:

Testing file [SQOOP-1969.patch|https://issues.apache.org/jira/secure/attachment/12690051/SQOOP-1969.patch]
against branch sqoop2 took 0:26:50.302957.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} Patch does not add/modifny any test case
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed
{color:green}SUCCESS:{color} All integration tests passed

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/867/console].

This message is automatically generated.

> Support getColumnSize method for Schema class
> ---------------------------------------------
>                 Key: SQOOP-1969
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1969
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: connectors/generic
>    Affects Versions: 2.0.0
>            Reporter: Jerry Chen
>            Assignee: Qian Xu
>         Attachments: SQOOP-1969.patch
> Currently, Schema class don't have getColumnSize method. There are a lot of places in
Matcher implementations getMatchingData calling getColumnsArray().length to purely get the
column size. While getColumnsArray a method not efficient as it looks like:
> {quote}
> public Column[] getColumnsArray() 
>     return columns.toArray(new Column[columns.size()]);
> {quote}
> It is suggested to add getColumnSize method in schema and the caller can use this method
to return the column length. 
> This problem gets serious because getMatchingData is called repeatedly with each record
in Mapper.

This message was sent by Atlassian JIRA

View raw message