sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1969) Support getColumnSize method for Schema class
Date Mon, 05 Jan 2015 11:46:35 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264510#comment-14264510
] 

Hudson commented on SQOOP-1969:
-------------------------------

SUCCESS: Integrated in Sqoop2-hadoop200 #686 (See [https://builds.apache.org/job/Sqoop2-hadoop200/686/])
SQOOP-1969: Support getColumnSize method for Schema class (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1cf075fdff3b685073f6d079f8dee44776701c2e)
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java
* connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java
* common/src/main/java/org/apache/sqoop/schema/Schema.java


> Support getColumnSize method for Schema class
> ---------------------------------------------
>
>                 Key: SQOOP-1969
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1969
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: connectors/generic
>    Affects Versions: 2.0.0
>            Reporter: Jerry Chen
>            Assignee: Qian Xu
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1969.patch
>
>
> Currently, Schema class don't have getColumnSize method. There are a lot of places in
Matcher implementations getMatchingData calling getColumnsArray().length to purely get the
column size. While getColumnsArray a method not efficient as it looks like:
> {quote}
> public Column[] getColumnsArray() 
>     return columns.toArray(new Column[columns.size()]);
> {quote}
> It is suggested to add getColumnSize method in schema and the caller can use this method
to return the column length. 
> This problem gets serious because getMatchingData is called repeatedly with each record
in Mapper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message