sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SQOOP-2018) GenericJDBCConnector SqlTypes INTEGER should be set 4 bytes
Date Thu, 15 Jan 2015 16:07:35 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278861#comment-14278861
] 

Veena Basavaraj edited comment on SQOOP-2018 at 1/15/15 4:06 PM:
-----------------------------------------------------------------

[~stanleyxu2005] there is test, but this is case where even test assumed it to be 2L byteSize
in unit test. As I have been hinting since a while, we need a very comprehensive dataset in
the integration test suite for all DBs we want to support and the 14 data types to catch these
issues.

our current dataset is and only for Derby.
{code}

  @Override
  public DataSet createTables() {
    provider.createTable(
      tableBaseName,
      "id",
      "id", "int",
      "country", "varchar(50)",
      "city", "varchar(50)"
    );
  @Override
  public DataSet createTables() {
    provider.createTable(
      tableBaseName,
      "id",
      "id", "int",
      "code_name", "varchar(64)",
      "version", "numeric(4,2)",
      "release_date", "date",
      "lts", "boolean"
    );
{code}

atleast we have one field with date, but no  time datetime, decimal, float, ints that are
> 2L, maps, arrays, enums


was (Author: vybs):
[~stanleyxu2005] there is test, but this is case where even test assumed it to be 2L byteSize
in unit test. As I have been hinting since a while, we need a very comprehensive dataset in
the integration test suite for all DBs we want to support and the 14 data types to catch these
issues.

our current dataset is and only for Derby.
{code}

  @Override
  public DataSet createTables() {
    provider.createTable(
      tableBaseName,
      "id",
      "id", "int",
      "country", "varchar(50)",
      "city", "varchar(50)"
    );

{code}

> GenericJDBCConnector SqlTypes INTEGER should be set 4 bytes
> -----------------------------------------------------------
>
>                 Key: SQOOP-2018
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2018
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-2018.patch
>
>
> treat INT as 4 bytes since both MySQL and Oracle and Postgres do it so
> http://dev.mysql.com/doc/refman/5.0/en/integer-types.html
> https://docs.oracle.com/cd/E17952_01/refman-5.5-en/storage-requirements.html
> http://www.postgresql.org/docs/9.1/static/datatype-numeric.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message