sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 31728: SQOOP-2170 MySQL specific tests are not properly cleaning up created tables
Date Thu, 05 Mar 2015 00:32:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31728/#review75268
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On March 4, 2015, 4:51 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31728/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 4:51 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I found the current MySQL tests a bit messy - there is a lot of copy&pasted code
around. As MySQL tests are extending normal HSQLDB tests, I did not wanted to completely refactore
them as that would be quite intrusive change. Instead I've chosen approach of ensuring that
each test is simply cleaning up the tables properly - this means that I've put a lot of similar
code to all MySQL tests. Whereas not perfect, this have been intentional at the moment.
> 
> 
> Diffs
> -----
> 
>   src/test/com/cloudera/sqoop/TestAllTables.java d2c7b16 
>   src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java eac7836 
>   src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java b7d6284 
>   src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java f7cc297 
>   src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java 3be447e 
> 
> Diff: https://reviews.apache.org/r/31728/diff/
> 
> 
> Testing
> -------
> 
> I've run all the affected tests, they are passing and are properly cleaning up the testing
tables.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message