sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 32195: SQOOP-2226: Add "Access Denied" in ShowLinkFunction.java
Date Mon, 23 Mar 2015 21:29:54 GMT


> On March 19, 2015, 1:37 a.m., Abraham Elmahrek wrote:
> > shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java, line 149
> > <https://reviews.apache.org/r/32195/diff/1/?file=898822#file898822line149>
> >
> >     This clobbers all exceptions. Is there a Auth specific exception we can catch?
If not, I'd say let's add one that extends SqoopException.

We can also check the SqoopException and re-raise if it's something else.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32195/#review76995
-----------------------------------------------------------


On March 18, 2015, 8:14 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32195/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 8:14 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> When run "show link" in CLI, the connector name displays in the summary page.
> +----+-------+--------------+------------------------+---------+
> | Id | Name  | Connector Id |     Connector Name     | Enabled |
> +----+-------+--------------+------------------------+---------+
> | 1  | mysql | 4            | generic-jdbc-connector | true    |
> | 2  | kafka | 1            | kite-connector         | true    |
> +----+-------+--------------+------------------------+---------+
> If user has privilege of READ LINK, and has not privilege of READ CONNECOTR, then SqoopException
will be thrown.
> After this JIRA, the result will be showed below.
> +----+-------+--------------+------------------------+---------+
> | Id | Name  | Connector Id |     Connector Name     | Enabled |
> +----+-------+--------------+------------------------+---------+
> | 1  | mysql | 4            | generic-jdbc-connector | true    |
> | 2  | kafka | 1            | Access Denied          | true    |
> +----+-------+--------------+------------------------+---------+
> 
> 
> Diffs
> -----
> 
>   shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 1a5f354603108ba024ed3e66bb49af1e2590a5fe

> 
> Diff: https://reviews.apache.org/r/32195/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message