sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 32275: SQOOP-2246 Sqoop2: Generic JDBC: Use jdbcProperties when creating database connection in GenericJDBCExecutor
Date Mon, 23 Mar 2015 22:19:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32275/#review77479
-----------------------------------------------------------



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
<https://reviews.apache.org/r/32275/#comment125566>

    The same JVM instance might load the class twice? In some JDBC drivers, they do some static
initialization. Doing that twice can cause problems. I've seen this when testing MySQL to
PostgreSQL and vice versa.



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
<https://reviews.apache.org/r/32275/#comment125567>

    Awesome!



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
<https://reviews.apache.org/r/32275/#comment125568>

    Kind of a new feature I'd say. We never accepted passwordless login in the past. Cool!


- Abraham Elmahrek


On March 20, 2015, 1:32 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32275/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 1:32 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2246
>     https://issues.apache.org/jira/browse/SQOOP-2246
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've updated the Executor constructor to take entire link configuration object rather
then few specific arguments. This way any new added configuration options will be immediatelly
available in the executor without need to add another parameter to the constructor.
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
5af34a5 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
3287e16 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
6ad2cab 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
ab1ac86 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
e381651 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
400c0f2 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
c3b8171 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java
67ba5bf 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
803d37b 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
e9c8d41 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
2479f89 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
a61de7d 
> 
> Diff: https://reviews.apache.org/r/32275/diff/
> 
> 
> Testing
> -------
> 
> All tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message