sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "shen guoquan" <guoquan.s...@intel.com>
Subject Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for sentry authorization
Date Tue, 24 Mar 2015 03:10:32 GMT


> On 三月 21, 2015, 6:13 a.m., Prasad Mujumdar wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java,
line 30
> > <https://reviews.apache.org/r/31575/diff/3/?file=897636#file897636line30>
> >
> >     Nit: ALL=READ|WRITE instead of hardcodeing 3
> 
> shen guoquan wrote:
>     Good advice. I will fix it. Thanks Prasad

By the way. Could you help me mark +1 on the SENTRY-645. Thanks for your help, Prasad :)


- shen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------


On 三月 17, 2015, 8:50 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
> 
> (Updated 三月 17, 2015, 8:50 a.m.)
> 
> 
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng
Sun, and Prasad Mujumdar.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
> 
> 
> Diffs
> -----
> 
>   pom.xml 4c80916 
>   sentry-core/pom.xml 1552133 
>   sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java
PRE-CREATION 
>   sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java
PRE-CREATION 
>   sentry-dist/pom.xml f63b33b 
> 
> Diff: https://reviews.apache.org/r/31575/diff/
> 
> 
> Testing
> -------
> 
> Ran included unit tests.
> 
> 
> Thanks,
> 
> shen guoquan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message