sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <qian.a...@intel.com>
Subject Re: Review Request 32427: SQOOP-2255: Throw Exception when no permission to the resource
Date Tue, 24 Mar 2015 03:54:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32427/#review77521
-----------------------------------------------------------



server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
<https://reviews.apache.org/r/32427/#comment125611>

    It looks a bit tricky. If you are confident that there are at most one connector to check,
then leave a comment here.



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/32427/#comment125612>

    dito (Why `size==1`)



server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
<https://reviews.apache.org/r/32427/#comment125613>

    dito (Why `size==1`)


- Qian Xu


On March 24, 2015, 11:25 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32427/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 11:25 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> When getting multi-connectors/links/jobs, AuthorizationEngine.filterResource is used
to filter resources according to the permissions.
> When getting one specific connector/link/job via id, this resource should be checked
permission, and throw exception if no privilege.
> 
> 
> Diffs
> -----
> 
>   security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java
d261027ff5aefa728c5f761534f4439264b4ae45 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 2305a51472a0201771fe493e8364f7db62ee79a2

>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 70108f64b12ef3068e746a61dc53f5fd06f99f23

>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 3187bcf00b51533cc33513a315dd9f1296e58c6d

> 
> Diff: https://reviews.apache.org/r/32427/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message