sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 32154: SQOOP-2220: Fix the privilege check on job using the link id not the connector id
Date Tue, 24 Mar 2015 06:18:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32154/#review77532
-----------------------------------------------------------

Ship it!


LGTM except for one thing


common/src/main/java/org/apache/sqoop/model/MJob.java
<https://reviews.apache.org/r/32154/#comment125645>

    getLinkId(Direction direction) instead? To be in line with getConnectorId?


- Abraham Elmahrek


On March 17, 2015, 8:23 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32154/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 8:23 a.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek and richard zhou.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The privilege check on job should use the link id not the connector id
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MJob.java 4b5c896 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 551d5fe 
> 
> Diff: https://reviews.apache.org/r/32154/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shen guoquan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message