sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2159) Sqoop2: Use BeforeSuite/AfterSuite for startHadoop/stopHadoop in integration tests
Date Tue, 03 Mar 2015 03:05:08 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344413#comment-14344413
] 

Hudson commented on SQOOP-2159:
-------------------------------

SUCCESS: Integrated in Sqoop2-hadoop200 #769 (See [https://builds.apache.org/job/Sqoop2-hadoop200/769/])
SQOOP-2159: Sqoop2: Use BeforeSuite/AfterSuite for startHadoop/stopHadoop in integration tests
(abe: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=68595856f6f9e51cc176510aff55dbaf18e36163)
* test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
* test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java


> Sqoop2: Use BeforeSuite/AfterSuite for startHadoop/stopHadoop in integration tests
> ----------------------------------------------------------------------------------
>
>                 Key: SQOOP-2159
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2159
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.5
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.6
>
>         Attachments: SQOOP-2159.patch
>
>
> I've noticed that {{BeforeClass}} annotation in test-ng is behaving slightly differently
than I was expecting. For most integration tests it behaves as anticipated - it will run before
any test methods inside any test class. However when it's used with {{@DataProvider}} it will
be run for every parametrized call. This means that for example {{PartitionerTest}} will initialize
the {{HadoopMiniCluster}} on all 20 executions, which is adding to the slowness of this test.
> Test-ng have additional annotation called {{@BeforeSuite}} that will run only once even
if given test class is using {{@DataProvider}} and hence I would suggest to use it for {{startHadoop()}}
method. And similarly {{@AfterSuite}} for {{stopHadoop()}}.
> I did not measure impact on {{PartitionerTest}}, but making this change for other integration
test that I'm writing got the execution from 10 down to 3 minutes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message