sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sqoop QA bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2239) Sqoop2: Remove Repository.updateSubmission() call from Mapreduce submission engine
Date Tue, 24 Mar 2015 00:37:52 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376999#comment-14376999
] 

Sqoop QA bot commented on SQOOP-2239:
-------------------------------------

Testing file [SQOOP-2239.patch|https://issues.apache.org/jira/secure/attachment/12705666/SQOOP-2239.patch]
against branch sqoop2 took 0:55:30.073924.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} Patch does not add/modifny any test case
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All fast unit tests passed (executed 671 tests)
{color:green}SUCCESS:{color} All slow unit tests passed (executed 1 tests)
{color:green}SUCCESS:{color} All fast integration tests passed (executed 46 tests)
{color:green}SUCCESS:{color} All slow integration tests passed (executed 20 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1210/console].

This message is automatically generated.

> Sqoop2: Remove Repository.updateSubmission() call from Mapreduce submission engine
> ----------------------------------------------------------------------------------
>
>                 Key: SQOOP-2239
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2239
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.5
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.6
>
>         Attachments: SQOOP-2239.patch
>
>
> Current mapreduce submission engine is updating repository when getting latest information
about submission. This is unfortunate because it's breaking encapsulation - submission engine
should be responsible only for updating the submission itself not to also persist it's state
in repository. That is responsibility of the core JobManager itself. This way we will also
ensure that we will persist the updated submission regardless what submission engine will
be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message