sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2249) Sqoop2: ErrorCodes: Move SecurityError to core module
Date Tue, 24 Mar 2015 13:34:53 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377843#comment-14377843
] 

Jarek Jarcec Cecho commented on SQOOP-2249:
-------------------------------------------

I believe that we've moved the {{*Error}} classes to a {{sqoop-common}} just because of SQOOP-2225
that I've fixed recently, so I wanted to move them back where they belong [~richard_zhou].
If we put maven modules into a tree like structure, then the error classes (as well as any
other classes) should be in a module that is the least common denominator by all other modules
that requires that class. Otherwise we pretty much could repeat what we've done with Sqoop
1 and have one maven module with all the code. Both {{RepositoryError}} and {{ServerError}}
seems to be used only in {{sqoop-core}} and it's children, so I'm not sure why we would have
it in {{sqoop-common}}.

I'm wondering if there was a different reason why to move those {{*Error}} classes to {{sqoop-common}}
other then the fixed SQOOP-2225?

> Sqoop2: ErrorCodes: Move SecurityError to core module
> -----------------------------------------------------
>
>                 Key: SQOOP-2249
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2249
>             Project: Sqoop
>          Issue Type: Sub-task
>    Affects Versions: 1.99.5
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.6
>
>         Attachments: SQOOP-2249.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message