sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "shen guoquan" <guoquan.s...@intel.com>
Subject Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework for role-based authorization
Date Fri, 17 Apr 2015 01:17:11 GMT


> On 四月 16, 2015, 10:47 p.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java,
line 86
> > <https://reviews.apache.org/r/31657/diff/5/?file=918735#file918735line86>
> >
> >     The new object is never assigned to instance. It will always be null.

I am sorry for that mistake. I will fix it. Thanks Prasad


- shen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80389
-----------------------------------------------------------


On 四月 7, 2015, 3:29 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
> 
> (Updated 四月 7, 2015, 3:29 a.m.)
> 
> 
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng
Sun, and Prasad Mujumdar.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Sentry Sqoop binding framework for role-based authorization
> 
> 
> Diffs
> -----
> 
>   pom.xml 0cfe260 
>   sentry-binding/pom.xml b903ab3 
>   sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION

>   sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION

>   sentry-dist/pom.xml 5ebfa69 
>   sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java
def3486 
> 
> Diff: https://reviews.apache.org/r/31657/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests
> 
> 
> Thanks,
> 
> shen guoquan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message