sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework for role-based authorization
Date Sat, 25 Apr 2015 01:53:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review81580
-----------------------------------------------------------

Ship it!


Small nit :).


sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment132015>

    Hey this is named incorrectly: SentryAuthorizationHandler seems more right (missing the
'l' in Handler).
    
    Also, it seems sqoop has a capital A in Authorization. I'll get on top of that in the
Sqoop community.


- Abraham Elmahrek


On April 17, 2015, 2:42 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 2:42 a.m.)
> 
> 
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng
Sun, and Prasad Mujumdar.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Sentry Sqoop binding framework for role-based authorization
> 
> 
> Diffs
> -----
> 
>   pom.xml 90ecea1 
>   sentry-binding/pom.xml b903ab3 
>   sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml
PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION

>   sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION

>   sentry-dist/pom.xml 51e05a5 
>   sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java
def3486 
> 
> Diff: https://reviews.apache.org/r/31657/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests
> 
> 
> Thanks,
> 
> shen guoquan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message