sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 34104: Fix for SQOOP-1369 Avro export ignores --columns option
Date Tue, 12 May 2015 20:14:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34104/#review83442
-----------------------------------------------------------


I think there are a few other places where getColumnNames is extended. Not sure if it's worth
adding there.

Also, I highly recommend adding tests to make sure this doesn't come back.


src/java/org/apache/sqoop/manager/SqlManager.java
<https://reviews.apache.org/r/34104/#comment134430>

    Can be a Set type like TreeSet. Some times users have hundreds to thousands of columns
that they specify.



src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java
<https://reviews.apache.org/r/34104/#comment134434>

    Use TreeSet?


- Abraham Elmahrek


On May 12, 2015, 1:14 p.m., Paul Mazak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34104/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 1:14 p.m.)
> 
> 
> Review request for Sqoop and Yibing Shi.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Supplied a patch that worked for us. 
> There are 2 global places to consider - parent class SqlManager and child class CatalogQueryManager
- when returning getColumnNames to actually rely on those column names you specified with
--columns option. 
> There was 1 place to consider for Avro/Parquet in JdbcExportJob.configureGenericRecordExportInputFormat()
to only add the columnType if it's one that was specified with --columns option.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/CatalogQueryManager.java 4e063ed 
>   src/java/org/apache/sqoop/manager/SqlManager.java ead581d 
>   src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java 93d438a 
> 
> Diff: https://reviews.apache.org/r/34104/diff/
> 
> 
> Testing
> -------
> 
> Integration testing passed exporting AVRO to MS SQL Server
> 
> 
> Thanks,
> 
> Paul Mazak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message