sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <qian.a...@intel.com>
Subject Re: Review Request 34282: Sqoop2: Upgrade should consider both directions for a single connector
Date Mon, 18 May 2015 03:12:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34282/#review84097
-----------------------------------------------------------



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/34282/#comment135205>

    In general +1. 
    
    The result validation code occur three times and seem to be very similiar. Do you think
this part of code can be moved into a method?


- Qian Xu


On May 16, 2015, 2:16 a.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34282/
> -----------------------------------------------------------
> 
> (Updated May 16, 2015, 2:16 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2360
>     https://issues.apache.org/jira/browse/SQOOP-2360
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 0e53a1b46e116f360fc1d028457cf1614e8b2ab0
> Author: Abraham Elmahrek <abe@apache.org>
> Date:   Wed May 13 17:42:56 2015 -0700
> 
>     SQOOP-2360: Sqoop2: Upgrade should consider both directions for a single connector
> 
> :100644 100644 aa91661... 8cbff99... M  core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 9b153fc... f571c80... M  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
> :100644 100644 85ce8ff... 9ee0379... M  test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java
> :100644 100644 7a6ceed... 5912e7c... M  test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java aa91661f846527b7ead52cedd08476500d36cc65

>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 9b153fc535e66d34ca8b2d81d28f012619ce8d3d

>   test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java
85ce8ff5b1fffa7965dec2ccb7839cac94110abe 
>   test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz 7a6ceed1023a1929b54c145b1db81e1c8e66beb9

> 
> Diff: https://reviews.apache.org/r/34282/diff/
> 
> 
> Testing
> -------
> 
> mvn clean integration-test
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message