sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Re: Review Request 35122: Sqoop2: findJob will throw exception when job doesn't exist
Date Mon, 08 Jun 2015 14:14:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35122/
-----------------------------------------------------------

(Updated June 8, 2015, 2:14 p.m.)


Review request for Sqoop.


Bugs: sqoop-2390
    https://issues.apache.org/jira/browse/sqoop-2390


Repository: sqoop-sqoop2


Description
-------

findConnector return null when connector doesn't exist, while findJob and findLink throw exception
when job and link doesn't exist. This is inconsistent.


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java 7b8fce5 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
774c3b4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
6f975a6 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
1ee7996 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java
ad601b4 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java
35736d4 

Diff: https://reviews.apache.org/r/35122/diff/


Testing
-------


Thanks,

Dian Fu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message