sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Review Request 35216: Signature of method getConnectorIdFromIdentifier in HandlerUtils is inconsistent with other methods
Date Mon, 08 Jun 2015 15:04:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35216/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2395
    https://issues.apache.org/jira/browse/SQOOP-2395


Repository: sqoop-sqoop2


Description
-------

In HandlerUtils.java, there are three methods and the other two methods both take "String
identifier, Repository repository" as the signature. Making method getConnectorIdFromIdentifier
also taking "String identifier, Repository repository" as the signature will makes the code
more consistent.


Diffs
-----

  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java d1537bf 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5128a27 
  server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 93ff60b 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c96d66d 

Diff: https://reviews.apache.org/r/35216/diff/


Testing
-------


Thanks,

Dian Fu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message