sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "richard zhou" <richard.z...@intel.com>
Subject Re: Review Request 34930: SQOOP-2386: Sqoop2: refactor code in HandlerUtils
Date Tue, 09 Jun 2015 03:09:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34930/#review87123
-----------------------------------------------------------

Ship it!


LGTM

- richard zhou


On June 8, 2015, 2:49 p.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34930/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 2:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: sqoop-2386
>     https://issues.apache.org/jira/browse/sqoop-2386
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> In HandlerUtils, there is code like this:
>  if (repository.findJob(identifier) != null) {
>       jobId = repository.findJob(identifier).getPersistenceId();
>       ...
>  }
> This will execute repository.findJob twice, this is unnecessary.
> 
> 
> Diffs
> -----
> 
>   server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 93ff60b 
> 
> Diff: https://reviews.apache.org/r/34930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message