sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 35500: hive.metastore.sasl.enabled should be set to true for Oozie integration
Date Tue, 16 Jun 2015 17:12:38 GMT


> On June 16, 2015, 4:29 p.m., Qian Xu wrote:
> > src/java/org/apache/sqoop/hive/HiveImport.java, line 332
> > <https://reviews.apache.org/r/35500/diff/2/?file=985632#file985632line332>
> >
> >     Generally +1. 
> >     
> >     One NIT: As the similar code appears twice, do you think if we could have a
private method `private String[] getHiveArgs(String... extraArgs)` to create the argument
array?

Makes sense. Will work with Lists instead though.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/#review88079
-----------------------------------------------------------


On June 16, 2015, 9:57 a.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35500/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 9:57 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2400
>     https://issues.apache.org/jira/browse/SQOOP-2400
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> commit 8102d2445812718c37e6da1976fb1ecc2322a03a
> Author: Abraham Elmahrek <abe@apache.org>
> Date:   Sun May 31 09:52:58 2015 -0700
> 
>     SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
> 
> :100644 100644 097d622... 59a458b... M  src/java/org/apache/sqoop/hive/HiveImport.java
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/hive/HiveImport.java 097d622 
> 
> Diff: https://reviews.apache.org/r/35500/diff/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message