sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1965) Sqoop2: Naming support for Connector, Link, Job instances
Date Mon, 22 Jun 2015 04:26:01 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595345#comment-14595345
] 

Abraham Elmahrek commented on SQOOP-1965:
-----------------------------------------

[~banmeet.singh], I'm +1 on this change with the exception of the following change:
{code}
diff --git a/shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java b/shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java
index 70f268f..f7dbf33 100644
--- a/shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java
+++ b/shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java
@@ -47,9 +47,9 @@ public ShowLinkFunction() {
         .withDescription(resourceString(Constants.RES_SHOW_PROMPT_DISPLAY_ALL_LINKS))
         .withLongOpt(Constants.OPT_ALL)
         .create(Constants.OPT_ALL_CHAR));
-    this.addOption(OptionBuilder.hasArg().withArgName(Constants.OPT_LID)
+    this.addOption(OptionBuilder.hasArg().withArgName(Constants.OPT_FROM)
         .withDescription(resourceString(Constants.RES_SHOW_PROMPT_DISPLAY_LINK_LID))
-        .withLongOpt(Constants.OPT_LID)
+        .withLongOpt(Constants.OPT_FROM)
         .create(Constants.OPT_LID_CHAR));
   }
{code}

> Sqoop2: Naming support for Connector, Link, Job instances
> ---------------------------------------------------------
>
>                 Key: SQOOP-1965
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1965
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: sqoop2-api, sqoop2-shell
>    Affects Versions: 2.0.0
>            Reporter: Jerry Chen
>            Assignee: Banmeet Singh
>              Labels: newbie
>             Fix For: 2.0.0
>
>         Attachments: SQOOP-1965-1.patch, SQOOP-1965-2.patch, SQOOP-1965-3-1.patch, SQOOP-1965.patch
>
>
> Currently, each connector, link or job instances are identified by an numbered id. (Automatically
allocated by increment?) 
> The id is used everywhere in the shell to refer to the specific object instance. For
example, when creating a Job, link id number are specified as from or to link.
> Using of numbered id is simple for the implementation but the numbered id is very difficult
to make reference and hard to remember.
> It is a common practice to give a meaningful name to each instance and thus can be referenced
with the name. This can dramatically increase the usability of the system. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message