sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sqoop QA bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2386) Sqoop2: refactor code in HandlerUtils
Date Mon, 08 Jun 2015 15:48:01 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577377#comment-14577377
] 

Sqoop QA bot commented on SQOOP-2386:
-------------------------------------

Testing file [SQOOP-2386.2.patch|https://issues.apache.org/jira/secure/attachment/12738364/SQOOP-2386.2.patch]
against branch sqoop2 took 0:38:46.186776.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} Patch does not add/modifny any test case
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All fast unit tests passed (executed 682 tests)
{color:green}SUCCESS:{color} All slow unit tests passed (executed 1 tests)
{color:green}SUCCESS:{color} All fast integration tests passed (executed 27 tests)
{color:green}SUCCESS:{color} All slow integration tests passed (executed 42 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1399/console].

This message is automatically generated.

> Sqoop2: refactor code in HandlerUtils
> -------------------------------------
>
>                 Key: SQOOP-2386
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2386
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2386.1.patch, SQOOP-2386.2.patch
>
>
> In {{HandlerUtils}}, there is code like this:
> {code}
>  if (repository.findJob(identifier) != null) {
>       jobId = repository.findJob(identifier).getPersistenceId();
>       ...
>  }
> {code}
> This will execute {{repository.findJob}} twice, this is unnecessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message