sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2386) Sqoop2: refactor code in HandlerUtils
Date Wed, 10 Jun 2015 05:07:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580027#comment-14580027
] 

Dian Fu commented on SQOOP-2386:
--------------------------------

Thanks [~abec] and [~richard_zhou] for review and commit.

> Sqoop2: refactor code in HandlerUtils
> -------------------------------------
>
>                 Key: SQOOP-2386
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2386
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2386.1.patch, SQOOP-2386.2.patch
>
>
> In {{HandlerUtils}}, there is code like this:
> {code}
>  if (repository.findJob(identifier) != null) {
>       jobId = repository.findJob(identifier).getPersistenceId();
>       ...
>  }
> {code}
> This will execute {{repository.findJob}} twice, this is unnecessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message