sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 36445: SQOOP-2414: Change JUnit Assert class to TestNG Assert class
Date Mon, 13 Jul 2015 14:42:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36445/#review91468
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On July 13, 2015, 8:29 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36445/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 8:29 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Change JUnit Assert class to TestNG Assert class
> 
> 
> Diffs
> -----
> 
>   client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 0c6fa621063598108b600a49dcb715265a3d6ca5

>   common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
505e084fdf73e2dbec926c0c09f6b3ad59a88db2 
>   common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java f328e93917c2001e4fa5f287328351b881578e99

>   common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java 77b8f5216c6a80863bf1d97e7a707b208f866fcf

>   common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 9297533db1212f7166ad57542f3c412a166bc3fb

>   common/src/test/java/org/apache/sqoop/json/TestJSONUtils.java 4e80ec70719fc043ae07c5abbbf27b28a1f4d04e

>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 40090298edadd388eb80c9e786601e41ab7a2153

>   common/src/test/java/org/apache/sqoop/json/TestJobsBean.java b73ad2135e08aa55333f6bf6c6d5fb3e7867724a

>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac2c824e348be999f747c3d8284b9448c66d29b9

>   common/src/test/java/org/apache/sqoop/json/TestLinksBean.java c6b100722b6ec3ca4c6d47ec1f2e66b98112c430

>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 74081ae089fa87d0c0b8863170520af1f82869a8

>   common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java d7ebf54c485329f836195ddf2862aafd1e99cdf6

>   common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 1ba78c8d40080528c066bbd0ff75cbc2579019f5

>   common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 368502fb36485cf8216e532d154fce697fc34593

>   common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 45b34a9dde6b746fd8846234e08cd209b6dfc62b

>   common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 472bbcea9e85a8512bcc25695099337439b303be

>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java b05e778a5f97b85261b5701f85616e66fdf11eb5

>   common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java 3e863fae7a836a2925dc7d11cbf2d30ebc545989

>   common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 6550dde93d20b627969e73ec420f81783391047c

>   common/src/test/java/org/apache/sqoop/model/TestMConnector.java 57afee6942da690c429aee721ecf5847b9008a42

>   common/src/test/java/org/apache/sqoop/model/TestMDriver.java 3acb27e78b9f559b3c1a89d5a32eb47e0c9442c0

>   common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 744ac501fc877f66f712a61cb49473265aa595eb

>   common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 2c3decf2a965b0ed7c9d5286abc5e9235fc12d12

>   common/src/test/java/org/apache/sqoop/model/TestMJob.java 4f36b4bed332b09f9bf4788e4db16f0f814d74b7

>   common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 53a35492f59b177ba44722d03d063bb6a1eeb7b2

>   common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java 161a1fa071766523b9cacaa0caf5632159b7abde

>   common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java e2d4299a7f5c88b76f0c29a5f48359e092545b81

>   common/src/test/java/org/apache/sqoop/validation/validators/TestCSVURIValidator.java
ecbe08c50e6901921c29495688f2ab5f1f842153 
>   common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java
3b6e2feac978ce2d0ed997676d5d2ae7c1ad950d 
>   common/src/test/java/org/apache/sqoop/validation/validators/TestContains.java 3b5add5f835f153439d641dd2f0d351e2f6e691a

>   common/src/test/java/org/apache/sqoop/validation/validators/TestHostAndPortValidator.java
1c726ac8771091d19cadd989777d489fcb95aa72 
>   common/src/test/java/org/apache/sqoop/validation/validators/TestNotEmpty.java 70184485b9062affde4c616af986cc06f4f7700d

>   common/src/test/java/org/apache/sqoop/validation/validators/TestNotNull.java ee81e09ae37dc2d5b5c5ebb110b895219d4c71d7

>   common/src/test/java/org/apache/sqoop/validation/validators/TestNullOrContains.java
a23b50474f10d3307759e61ea457a0809ef102bd 
>   common/src/test/java/org/apache/sqoop/validation/validators/TestStartsWith.java 89b9671c934fc5ed002a2efae99c929cf287e79f

>   common/src/test/java/org/apache/sqoop/validation/validators/TestValidator.java 9b92480d07e6b32dc9968eb73a90f60be56425a3

>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
91f97f12ab1b7b606a91e7e30f9fbea979eb6485 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
9acc5c3e7d5c4639f6cc84a4f7dc2caaea73a1c6 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
5fc2a4a9e1cb2f6ea9ce48a8292acb9a01e09c6e 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java
2a3ab9b1d397f78db3d7ca4f990861624931ee6f 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
d423a6a43a3c75833c70b03c344a5af4b4ac299e 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java
e0bbf3f9cd074931a56ee3da2da6f7e5e149d129 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
04c5437e1198aa17a38058ef9cb802ceb04201f5 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
03b13bdced993d522c236befc8eada75a6b47118 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
c560c08365feebd31799966a3da62d2f5e634106 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLinkConfig.java
27a94c6778f4eeee250b0e9af9b0b408be7c1d0a 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
ff711287ead5ed5355a0f9c74e72ab52fededccf 
>   connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestConfiguration.java
ecdbdcac746000ccdb27ce3522b7bd2f0c41008a 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorUpgrader.java
741c81ee62e03194de9d50141c0499d4ba991ddd 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java
0e797f8d3d5a1e98221c7119d4a1fa199496db3a 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/configuration/TestConfigUtil.java
827024bddab90a4dbde9206db920e5d7198e3d35 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java
b9a5ea19ccb19407d5046090a99cc530d183c9e3 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
922963906b24bf1b14d9dabee1de5790efe07b0f 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java
0d9a1cf54e56b4f1e0c7f0bf403d7ae7864d6b18 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java
71b35a9ae3eccae7666c9732c98c72298de6d2d6 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java
9c4b1ba5dea49ae454d11b7615ca6fb5e1980c33 
>   core/src/test/java/org/apache/sqoop/connector/TestConnectorManagerUtils.java 258b5f9e7b11a82c5afde124f887c81c04da654d

>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 819a7d06699b385c6abc55994b416f26e76c8f32

>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 2a14ff2850ed71ff818db193c73e478a5383e9da

>   core/src/test/java/org/apache/sqoop/driver/TestJobRequest.java 4381b97fdbcfc40969ae18f055e0077a2a566529

>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java f571c80180b4f96cbd53e3a6992b84606955b54c

>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 10ed33c1c9e6dc339adab15e181617eadae9ad08

>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java f658d09a2bf8324f47033d99b76edb62b23b8cc9

>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java
b83de3b2bc6400c6461c81f53c346cd1f55ff223 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
d2e793c8873524df7dc4d86c1dbabb571b23a0bf 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
cacba4c96b5824a0e0a7a7f975f195192b74fcc5 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java
4a818276cc7831cbdf2fe27ee20a554e697b1143 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
fe872ca6afe44c965b56b0f9241640bb0b5e9d26 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
de5e3c8af284fc326769fbd34dc304461a5efb6a 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
2a36bd499b5c689c01d431dbe4156726450e7a4d 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java
e9b5bcdc746a1d0b9a09abdff604e3da0165eb37 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java
d48d49e4700af3135b5e8e4833121867c7319b3c 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java
cf8c1a330d1cc49ace7d8353458150e36298b036 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java
699fc423ecc9d8268b5c827950a33789ff6de338 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java
ffdf8e1272ddc5a85c651a50f7ee13ac65dd908b 
>   test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java 8d548ad3ac09163bb1f42f659ffc7da9f36260e0

>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 742073982b0b6f3bff223468d86ddadb7ecfe044

>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java
9e0e6d917c48e4eeb09de5210b8af92ccf521add 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
0a3a2c20556de058d41265fbefd009cf3f5da84e 
>   test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
203895ee2fa91032df608793319420d9e8e457e8 
>   test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
d305620615c62bd5916dc33a24a0a4215e9f8e21 
>   test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
40dc7d7b00d95ab54007d6d98accb538cd3d707f 
>   test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java a54492eb73d47d66c386536fc7e06cb199f419f4

> 
> Diff: https://reviews.apache.org/r/36445/diff/
> 
> 
> Testing
> -------
> 
> Integration Test
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message