sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SQOOP-2452) Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class
Date Thu, 30 Jul 2015 00:24:04 GMT

     [ https://issues.apache.org/jira/browse/SQOOP-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jarek Jarcec Cecho updated SQOOP-2452:
--------------------------------------
    Attachment: SQOOP-2452.patch

Simple patch, skipping review board.

> Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class
> ----------------------------------------------------------------------------------
>
>                 Key: SQOOP-2452
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2452
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2452.patch
>
>
> I feel that this one is more of a nit then a real problem, but findbugs is correct that
static inner class is better suited because it doesn't need any variables from the parent's
class scope.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message