sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2452) Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class
Date Thu, 30 Jul 2015 01:48:05 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647058#comment-14647058
] 

ASF subversion and git services commented on SQOOP-2452:
--------------------------------------------------------

Commit 3c88f553de57a6fc35bc4e2191bcb58384662d72 in sqoop's branch refs/heads/sqoop2 from [~abec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=3c88f55 ]

SQOOP-2452: Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class

(Jarek Jarcec Cecho via Abraham Elmahrek)


> Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class
> ----------------------------------------------------------------------------------
>
>                 Key: SQOOP-2452
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2452
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2452.patch
>
>
> I feel that this one is more of a nit then a real problem, but findbugs is correct that
static inner class is better suited because it doesn't need any variables from the parent's
class scope.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message