sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Ma" <junjie...@intel.com>
Subject Review Request 37120: SQOOP-2460: Refactor repository-common to make sqoop2 easy to use external DB as repository
Date Wed, 05 Aug 2015 07:35:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37120/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Currently, in the class CommonRepositoryInsertUpdateDeleteSelectQuery, the tableName and columnName
are wrapped with quotation, like "tableName"."columnName". But some db doesn't support this
format, like MySql.
Refactor the code in repository-common to fix this problem.


Diffs
-----

  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
73293c0 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
1b5e2fb 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
28f5f6a 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/RepositoryQuery.java
PRE-CREATION 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
2ba3384 

Diff: https://reviews.apache.org/r/37120/diff/


Testing
-------


Thanks,

Colin Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message