sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Re: Review Request 37120: SQOOP-2460: Refactor repository-common to make sqoop2 easy to use external DB as repository
Date Fri, 07 Aug 2015 05:55:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37120/#review94498
-----------------------------------------------------------


Hi Colin, thanks for the patch. A few comments as follows:
1) Seems that these three methods aren't used: getTableNameWithoutEscape/getColumnNameWithoutEscape/getConstraintNameWithoutEscape
2) The exsiting tables are created with double-quote. This means that the existing table names
are uppercase. If we access existing tables in PostgreSQL without double-quote, PostgreSQL
will firstly convert the table names to lowercase and then it won't find these tables.

- Dian Fu


On Aug. 5, 2015, 7:35 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37120/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 7:35 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Currently, in the class CommonRepositoryInsertUpdateDeleteSelectQuery, the tableName
and columnName are wrapped with quotation, like "tableName"."columnName". But some db doesn't
support this format, like MySql.
> Refactor the code in repository-common to fix this problem.
> 
> 
> Diffs
> -----
> 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
73293c0 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
1b5e2fb 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
28f5f6a 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/RepositoryQuery.java
PRE-CREATION 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
2ba3384 
> 
> Diff: https://reviews.apache.org/r/37120/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message