sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 37015: SQOOP-2450 Sqoop2: Precommit: Introduce findbugs checks
Date Wed, 12 Aug 2015 05:05:36 GMT


> On Aug. 11, 2015, 1:05 a.m., Abraham Elmahrek wrote:
> > dev-support/test-patch.py, line 422
> > <https://reviews.apache.org/r/37015/diff/1/?file=1027096#file1027096line422>
> >
> >     A note on python style:
> >        if not summary:
> >           ...
> >           
> >     Would also work!
> 
> Jarek Cecho wrote:
>     Thanks I did not know that :) Do you want me to update the patch or are we gonna
commit it as it is?

Your call! I'm fine the way it is.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37015/#review94829
-----------------------------------------------------------


On Aug. 1, 2015, 5:26 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37015/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 5:26 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2450
>     https://issues.apache.org/jira/browse/SQOOP-2450
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Rather then waiting on resolving SQOOP-2448 (all findbugs errors), I've decided to provide
solution that will only report newly introduced findbugs warnings.
> 
> 
> Diffs
> -----
> 
>   dev-support/test-patch.py 4bd5a7d 
> 
> Diff: https://reviews.apache.org/r/37015/diff/
> 
> 
> Testing
> -------
> 
> I did testing on my local box and it seems to be working :)
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message