sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 37380: SQOOP-2443 Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor
Date Wed, 12 Aug 2015 19:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37380/#review95146
-----------------------------------------------------------

Ship it!


Seems cool. A couple of thoughts and you're good.


connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
(line 138)
<https://reviews.apache.org/r/37380/#comment149981>

    Wondering if we should add debug logging about what primary keys were found.



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
(line 142)
<https://reviews.apache.org/r/37380/#comment149984>

    Add a note to the docs?



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
(line 145)
<https://reviews.apache.org/r/37380/#comment149982>

    Wondering if we can add debug logging about which primary key column was used specifically.


- Abraham Elmahrek


On Aug. 12, 2015, 2:18 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37380/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 2:18 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2443
>     https://issues.apache.org/jira/browse/SQOOP-2443
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Added support for compound primary key in to the Generic JDBC Executor.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java f18acbd

>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
1aeca7e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
9d8e4e7 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
a482ac4 
> 
> Diff: https://reviews.apache.org/r/37380/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message