sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 37121: SQOOP-2461: Add sqoop-repository-mysql to support MySql for the metadata repository
Date Thu, 13 Aug 2015 20:41:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37121/#review95324
-----------------------------------------------------------



repository/repository-mysql/pom.xml (line 51)
<https://reviews.apache.org/r/37121/#comment150230>

    I don't think the version is necessary.



repository/repository-mysql/pom.xml (lines 60 - 64)
<https://reviews.apache.org/r/37121/#comment150233>

    The Java MySQL JDBC connector has a GPL license. As long as we don't package/distribute
it, I think we're OK. I don't think we're currently distributing test jars.



repository/repository-mysql/pom.xml (lines 73 - 75)
<https://reviews.apache.org/r/37121/#comment150234>

    I don't think this part is necessary.



repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java
(line 84)
<https://reviews.apache.org/r/37121/#comment150229>

    Let's move this to CommonRepoHandler?



repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java
(line 181)
<https://reviews.apache.org/r/37121/#comment150227>

    I think we do this in all 3 of our repository handlers. Let's pull this into the CommonRepositoryHandler
in a separate Jira?



repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaCreateQuery.java
(lines 31 - 39)
<https://reviews.apache.org/r/37121/#comment150228>

    This info isn't necessary any more given we have it in the repository docs.
    
    Maybe we need a separate Jira to remove from the other places as well?


- Abraham Elmahrek


On Aug. 10, 2015, 8:35 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37121/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 8:35 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The sqoop-repository-mysql should be implemented with the sqoop-repository-comm.
> 
> 
> Diffs
> -----
> 
>   common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java dd4e546

>   common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 3083ee6

>   common/src/main/java/org/apache/sqoop/error/code/MySqlRepoError.java PRE-CREATION 
>   pom.xml 7bcb212 
>   repository/pom.xml c63595c 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
73293c0 
>   repository/repository-mysql/pom.xml PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepoConstants.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaCreateQuery.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaQuery.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MysqlRepositoryInsertUpdateDeleteSelectQuery.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestUtils.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestConnectorHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestDriverHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestHandler.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestJobHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestStructure.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestSubmissionHandling.java
PRE-CREATION 
>   server/pom.xml aabefc0 
> 
> Diff: https://reviews.apache.org/r/37121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message