sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 37121: SQOOP-2461: Add sqoop-repository-mysql to support MySql for the metadata repository
Date Wed, 19 Aug 2015 22:53:57 GMT


> On Aug. 13, 2015, 8:41 p.m., Abraham Elmahrek wrote:
> > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java,
line 84
> > <https://reviews.apache.org/r/37121/diff/2/?file=1035984#file1035984line84>
> >
> >     Let's move this to CommonRepoHandler?
> 
> Colin Ma wrote:
>     For this method, first release with Deby went out without system table, so there
has some addition code for DerbyRepositoryHandler. If possible, I'll create new JIRA to refactor
this.

Sounds good!


> On Aug. 13, 2015, 8:41 p.m., Abraham Elmahrek wrote:
> > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java,
line 181
> > <https://reviews.apache.org/r/37121/diff/2/?file=1035984#file1035984line181>
> >
> >     I think we do this in all 3 of our repository handlers. Let's pull this into
the CommonRepositoryHandler in a separate Jira?
> 
> Colin Ma wrote:
>     You're right, this method should be put in CommonRepositoryHandler, I'll create new
JIRA to trace this.

Sounds good!


> On Aug. 13, 2015, 8:41 p.m., Abraham Elmahrek wrote:
> > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaCreateQuery.java,
lines 31-39
> > <https://reviews.apache.org/r/37121/diff/2/?file=1035985#file1035985line31>
> >
> >     This info isn't necessary any more given we have it in the repository docs.
> >     
> >     Maybe we need a separate Jira to remove from the other places as well?
> 
> Colin Ma wrote:
>     I'll remove the information for this class.
>     For the other places, I'll create a separate JIRA to remove them.

Sounds good!


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37121/#review95324
-----------------------------------------------------------


On Aug. 14, 2015, 6:35 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37121/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 6:35 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The sqoop-repository-mysql should be implemented with the sqoop-repository-comm.
> 
> 
> Diffs
> -----
> 
>   common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java dd4e546

>   common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 3083ee6

>   common/src/main/java/org/apache/sqoop/error/code/MySqlRepoError.java PRE-CREATION 
>   pom.xml 7bcb212 
>   repository/pom.xml c63595c 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
73293c0 
>   repository/repository-mysql/pom.xml PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepoConstants.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaCreateQuery.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaQuery.java
PRE-CREATION 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MysqlRepositoryInsertUpdateDeleteSelectQuery.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestUtils.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestConnectorHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestDriverHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestHandler.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestJobHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestStructure.java
PRE-CREATION 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestSubmissionHandling.java
PRE-CREATION 
>   server/pom.xml aabefc0 
> 
> Diff: https://reviews.apache.org/r/37121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message