sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 37992: SQOOP-2550: Sqoop2: Findbugs: Add filter for the warning SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE and SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING
Date Tue, 01 Sep 2015 11:25:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37992/#review97274
-----------------------------------------------------------



pom.xml (lines 644 - 649)
<https://reviews.apache.org/r/37992/#comment153108>

    Might I suggest to add scope "provided" so that we're not dragging this JAR everywhere?
it seems to be useful only for compliation.


- Jarek Cecho


On Sept. 1, 2015, 6:40 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37992/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 6:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Add filter for the warning SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE and SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING
> 
> 
> Diffs
> -----
> 
>   common-test/pom.xml d08951b 
>   common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
c528e53 
>   common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 4f4d347

>   connector/connector-generic-jdbc/pom.xml 7bdeddb 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
a5315da 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
8bf43e4 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
909ed74 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
4e96644 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
80fbece 
>   pom.xml 25ad00c 
>   repository/repository-common/pom.xml c740117 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
ae1e1b2 
>   repository/repository-derby/pom.xml 2a3b8fc 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
0b68058 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java
738e593 
>   repository/repository-mysql/pom.xml 15e909e 
>   repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java
4917ffe 
>   repository/repository-postgresql/pom.xml bb3859f 
>   repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
0d0ea8c 
> 
> Diff: https://reviews.apache.org/r/37992/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message