sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Re: Review Request 37947: Sqoop2: Enforce resource name not null when creating table
Date Tue, 08 Sep 2015 00:45:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37947/
-----------------------------------------------------------

(Updated Sept. 8, 2015, 12:45 a.m.)


Review request for Sqoop.


Bugs: SQOOP-2539
    https://issues.apache.org/jira/browse/SQOOP-2539


Repository: sqoop-sqoop2


Description
-------

Currently resource name such as job name, connector name or link name can be null. We should
enforce that these resource names cannot be null.


Diffs (updated)
-----

  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
df41fb1 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
0b68058 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
6adf959 
  repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaCreateQuery.java
46493a3 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
0d0ea8c 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaUpgradeQuery.java
PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 63b1267 
  test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java 82043ea 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java e3e7bfe 
  test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java PRE-CREATION 
  test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_5UpgradeTest.java
PRE-CREATION 
  test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_6UpgradeTest.java
PRE-CREATION 
  test/src/test/resources/repository/derby/derby-repository-1.99.5.tar.gz PRE-CREATION 
  test/src/test/resources/repository/derby/derby-repository-1.99.6.tar.gz PRE-CREATION 

Diff: https://reviews.apache.org/r/37947/diff/


Testing
-------

mvn test


Thanks,

Dian Fu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message