sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Review Request 38175: Sqoop2: Enforce the element column in FromJobConfig of JDBC connector is a comma separated list
Date Tue, 08 Sep 2015 08:19:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38175/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2554
    https://issues.apache.org/jira/browse/SQOOP-2554


Repository: sqoop-sqoop2


Description
-------

We should enforce the column specified by user for JDBC connector is a comma separated list,
such as "column1, column2". Illegal inputs such as "column1 column2" should be denied.


Diffs
-----

  common/src/main/java/org/apache/sqoop/validation/validators/NullOrCommaSeparated.java PRE-CREATION

  common/src/test/java/org/apache/sqoop/validation/validators/TestNullOrCommaSeparated.java
PRE-CREATION 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
ec1c3b7 

Diff: https://reviews.apache.org/r/38175/diff/


Testing
-------


Thanks,

Dian Fu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message