sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Fine" <...@brightroll.com>
Subject Re: Review Request 38942: SQOOP-2598 Sqoop2: Main sqoop.log is missing log outputs from classes other then org.apache.sqoop
Date Mon, 05 Oct 2015 16:56:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38942/#review101486
-----------------------------------------------------------



common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java (line 30)
<https://reviews.apache.org/r/38942/#comment158897>

    maybe change the comment too?



dist/src/main/conf/sqoop.properties (line 56)
<https://reviews.apache.org/r/38942/#comment158894>

    why was the category removed from the logging pattern?



dist/src/main/conf/sqoop.properties (line 58)
<https://reviews.apache.org/r/38942/#comment158895>

    could making the default warn possibly be too talkative?


- Abraham Fine


On Oct. 1, 2015, 11:32 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38942/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 11:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2598
>     https://issues.apache.org/jira/browse/SQOOP-2598
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've made the changes proposed in JIRA.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java 1af8d7d 
>   core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java 49a380c 
>   dist/src/main/conf/sqoop.properties f077ecc 
>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 7440025

> 
> Diff: https://reviews.apache.org/r/38942/diff/
> 
> 
> Testing
> -------
> 
> I've valided on real cluster that:
> 
> * We're getting the audit logger as we were before in separate file
> * We see all the classes in the main log file
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message