sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 38942: SQOOP-2598 Sqoop2: Main sqoop.log is missing log outputs from classes other then org.apache.sqoop
Date Mon, 05 Oct 2015 17:22:30 GMT


> On Oct. 5, 2015, 4:56 p.m., Abraham Fine wrote:
> > common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java, line 30
> > <https://reviews.apache.org/r/38942/diff/1/?file=1088794#file1088794line30>
> >
> >     maybe change the comment too?

Good point, I'll address that.


> On Oct. 5, 2015, 4:56 p.m., Abraham Fine wrote:
> > dist/src/main/conf/sqoop.properties, line 56
> > <https://reviews.apache.org/r/38942/diff/1/?file=1088796#file1088796line56>
> >
> >     why was the category removed from the logging pattern?

Because I felt that it's redundant information - the %c{2} will print classname and the package
name immediately left of classname. However the [%1] will print full class name including
all packages. Check out the current log line:

2015-10-05 10:14:02,197 DEBUG common.CommonRepositoryHandler [org.apache.sqoop.repository.common.CommonRepositoryHandler.findDriver(CommonRepositoryHandler.java:325)]
Looking up Driver and config 

The fragment common.CommonRepositoryHandler is there twice.


> On Oct. 5, 2015, 4:56 p.m., Abraham Fine wrote:
> > dist/src/main/conf/sqoop.properties, line 58
> > <https://reviews.apache.org/r/38942/diff/1/?file=1088796#file1088796line58>
> >
> >     could making the default warn possibly be too talkative?

I'm not concerned about that - without INFO most of the log is pretty much useless as we don't
know what's going on. Originally Sqoop classes were configured for INFO as well and the warn
was only for "other" classes. As we're not running much other classes inside Sqoop, I'm not
anticipating that this change will have huge impact.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38942/#review101486
-----------------------------------------------------------


On Oct. 1, 2015, 11:32 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38942/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 11:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2598
>     https://issues.apache.org/jira/browse/SQOOP-2598
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've made the changes proposed in JIRA.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java 1af8d7d 
>   core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java 49a380c 
>   dist/src/main/conf/sqoop.properties f077ecc 
>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 7440025

> 
> Diff: https://reviews.apache.org/r/38942/diff/
> 
> 
> Testing
> -------
> 
> I've valided on real cluster that:
> 
> * We're getting the audit logger as we were before in separate file
> * We see all the classes in the main log file
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message