sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 38942: SQOOP-2598 Sqoop2: Main sqoop.log is missing log outputs from classes other then org.apache.sqoop
Date Mon, 05 Oct 2015 17:23:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38942/
-----------------------------------------------------------

(Updated Oct. 5, 2015, 5:23 p.m.)


Review request for Sqoop.


Changes
-------

Incorporated Abe's comments.


Bugs: SQOOP-2598
    https://issues.apache.org/jira/browse/SQOOP-2598


Repository: sqoop-sqoop2


Description
-------

I've made the changes proposed in JIRA.


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java 1af8d7d 
  core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java 49a380c 
  dist/src/main/conf/sqoop.properties f077ecc 
  test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 7440025 

Diff: https://reviews.apache.org/r/38942/diff/


Testing
-------

I've valided on real cluster that:

* We're getting the audit logger as we were before in separate file
* We see all the classes in the main log file


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message