sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 39280: SQOOP-2532
Date Tue, 13 Oct 2015 18:44:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39280/#review102509
-----------------------------------------------------------

Ship it!


Thank you for picking this up Abe, good work!

Would you mind separating the new validator to a separate JIRA? I would like to keep the JIRAs
as small as possible (while preserving that each commit do have a value) so that tools like
git cherry-pick and git blame are returing reasonable outcome.


connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
(line 156)
<https://reviews.apache.org/r/39280/#comment160187>

    Super nitpicky: We tend to use {} even for one line if statements, e.g.:
    
    if(something) {
      reallyDoItBro();
    }


Jarcec

- Jarek Cecho


On Oct. 13, 2015, 5:21 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39280/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2532
>     https://issues.apache.org/jira/browse/SQOOP-2532
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Generic JDBC Connector support for fetch size
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/error/code/CoreError.java bc3076c 
>   common/src/main/java/org/apache/sqoop/validation/validators/InRange.java PRE-CREATION

>   common/src/test/java/org/apache/sqoop/validation/validators/TestInRange.java PRE-CREATION

>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
ad6f649 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
5a357bd 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
ed215ea 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java
885c6f5 
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties
73fa308 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
5587840 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java
e16c631 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
dfacc20 
> 
> Diff: https://reviews.apache.org/r/39280/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message