sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sqoop QA bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2602) Sqoop2: Static initialization of ClassUtils defaultClassloader is fragile
Date Mon, 05 Oct 2015 20:59:27 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944029#comment-14944029
] 

Sqoop QA bot commented on SQOOP-2602:
-------------------------------------

Testing file [SQOOP-2602.patch|https://issues.apache.org/jira/secure/attachment/12765053/SQOOP-2602.patch]
against branch sqoop2 took 0:59:43.069372.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:orange}WARNING:{color} Patch applied, but there has been warnings:
{code}<stdin>:63: trailing whitespace.
  
warning: 1 line adds whitespace errors.
{code}

{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1434 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1754/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1754/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 89 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1754/console].

This message is automatically generated.

> Sqoop2: Static initialization of ClassUtils defaultClassloader is fragile
> -------------------------------------------------------------------------
>
>                 Key: SQOOP-2602
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2602
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Abraham Fine
>         Attachments: SQOOP-2602.patch
>
>
> While working with [~jarcec] on SQOOP-2490 we discovered an issue relating to the way
that {{ClassUtils}} reads the current class loader from the thread. In an integration testing
use case, we may want to append a new jar to the classpath (or remove jars) between tests.

> Currently, the {{defaultClassloader}} for {{ClassUtils}} is set in a {{static}} block,
this means that, should the connectors that are being used change between tests, {{ClassUtils}}
will be unable to reflect this change. We should change {{defaultClassloader}} to a method
that reads the class loader from the thread each time that it is called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message