sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2602) Sqoop2: Static initialization of ClassUtils defaultClassloader is fragile
Date Tue, 06 Oct 2015 00:01:30 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944283#comment-14944283
] 

Hudson commented on SQOOP-2602:
-------------------------------

SUCCESS: Integrated in Sqoop2 #913 (See [https://builds.apache.org/job/Sqoop2/913/])
SQOOP-2602: Sqoop2: Static initialization of ClassUtils (jarcec: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=89be1f7237277d4038660913259a8965c33c4011])
* common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java
* common/src/main/java/org/apache/sqoop/utils/ClassUtils.java


> Sqoop2: Static initialization of ClassUtils defaultClassloader is fragile
> -------------------------------------------------------------------------
>
>                 Key: SQOOP-2602
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2602
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2602.patch
>
>
> While working with [~jarcec] on SQOOP-2490 we discovered an issue relating to the way
that {{ClassUtils}} reads the current class loader from the thread. In an integration testing
use case, we may want to append a new jar to the classpath (or remove jars) between tests.

> Currently, the {{defaultClassloader}} for {{ClassUtils}} is set in a {{static}} block,
this means that, should the connectors that are being used change between tests, {{ClassUtils}}
will be unable to reflect this change. We should change {{defaultClassloader}} to a method
that reads the class loader from the thread each time that it is called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message