sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Re: Review Request 40619: SQOOP-2710 Sqoop2: Move user from context classes to parent TransferableContext
Date Wed, 25 Nov 2015 03:05:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40619/#review107907
-----------------------------------------------------------

Ship it!


Ship It!

- Dian Fu


On Nov. 23, 2015, 10:44 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40619/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 10:44 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2710
>     https://issues.apache.org/jira/browse/SQOOP-2710
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've moved the user property to parent class as suggested on JIRA.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java 38d94db 
>   common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 748bdfb 
>   common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java 7ad0d70 
>   common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java f0f2e38 
>   common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java b39497b 
>   common/src/main/java/org/apache/sqoop/job/etl/TransferableContext.java ad18e29 
> 
> Diff: https://reviews.apache.org/r/40619/diff/
> 
> 
> Testing
> -------
> 
> Unit tests seems to be passing. I didn't run integration tests, so let's wait on precommit
hook.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message